Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop incorrect TaskCanceledExceptions from HttpRequestPipeReader #33415

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Stop incorrect TaskCanceledExceptions from HttpRequestPipeReader #33415

merged 3 commits into from
Jun 14, 2021

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Jun 9, 2021 •
edited by BrennanConroy
Loading

Addresses #33373

@halter73 halter73 added this to the 6.0-preview6 milestone Jun 9, 2021
@BrennanConroy
Copy link
Member

Sniped 😆

@halter73 halter73 force-pushed the halter73/33373 branch 2 times, most recently from 02b940d to 2115a56 Compare June 9, 2021 21:26
JamesNK
JamesNK reviewed Jun 9, 2021
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test?

src/Servers/Kestrel/Core/src/Internal/Http/HttpRequestPipeReader.cs Outdated Show resolved Hide resolved
@halter73 @JamesNK
Update src/Servers/Kestrel/Core/src/Internal/Http/HttpRequestPipeRead…
55c31c1 
…er.cs

Co-authored-by: James Newton-King <james@newtonking.com>
@halter73
Copy link
Member Author

halter73 commented Jun 9, 2021 •
edited
Loading

Unit test?

This is fixing a hard-to-repro race condition reported by #33373. The behavioral difference shouldn't be observable with single-threaded access.

@JamesNK
Copy link
Member

JamesNK commented Jun 9, 2021

If it's not possible to unit test then that's fine.

@halter73 halter73 merged commit c245920 into main Jun 14, 2021
@halter73 halter73 deleted the halter73/33373 branch June 14, 2021 16:57
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanayParikh TanayParikh TanayParikh approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview6
Development

Successfully merging this pull request may close these issues.
5 participants
@halter73 @BrennanConroy @JamesNK @TanayParikh @amcasey