Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal APIs - return string aren't setting content type header #33860 #34285

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Minimal APIs - return string aren't setting content type header #33860 #34285

merged 5 commits into from
Jul 19, 2021

Conversation

rafikiassumani-msft
Copy link
Contributor

Set Content Type to Plain Text if ContextType Response header is not set

This change will set the contextType response header to "text/plain; charset=utf-8" when the content-type response header is null or was not set.

Addresses #33860

@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jul 12, 2021
@dnfadmin
Copy link

dnfadmin commented Jul 12, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

@BrennanConroy BrennanConroy removed the community-contribution Indicates that the PR has been added by a community member label Jul 12, 2021
@pranavkm @halter73
Apply suggestions from code review
8fa9ab2 
Co-authored-by: Stephen Halter <halter73@gmail.com>
pranavkm
pranavkm approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied some of the suggestions for you to try and get this in before we branch.

@pranavkm pranavkm enabled auto-merge (squash) July 15, 2021 17:57
auto-merge was automatically disabled July 15, 2021 19:34

Head branch was pushed to by a user without write access

@rafikiassumani-msft rafikiassumani-msft merged commit 6964c50 into dotnet:main Jul 19, 2021
@ghost ghost added this to the 6.0-rc1 milestone Jul 19, 2021
@rafikiassumani-msft rafikiassumani-msft linked an issue Aug 23, 2021 that may be closed by this pull request
Minimal APIs - return string isn't setting content type header #33860
Closed
@sebastienros sebastienros mentioned this pull request Sep 27, 2021
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher left review comments

@halter73 halter73 halter73 approved these changes

@pranavkm pranavkm pranavkm approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.

Minimal APIs - return string isn't setting content type header
7 participants
@rafikiassumani-msft @dnfadmin @halter73 @pranavkm @Tratcher @BrennanConroy @amcasey