Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0 Cleanup remaining SSP references #36248

Merged
merged 3 commits into from
Sep 9, 2021
Merged

[release/6.0 Cleanup remaining SSP references #36248

merged 3 commits into from
Sep 9, 2021

Commits on Sep 9, 2021

  1. [release/6.0 Cleanup remaining SSP references 

    - follow up to e58a6c2
- remove references to System.Security.Permissions or its closure
  - only mentions are in eng/PackageOverrides.txt and eng/PlatformManifest.txt
  - those files will remain unused until we update them in the run-up to 6.0.1
- still indirectly pick up package refs for SSP and its closure but that does not impact targeting pack content

nit: Only need to exclude System.Net.Quic and System.Security.Cryptography.Pkcs from `@(_AvailableRuntimeRefAssemblies)`
  - assemblies are not in `@(ReferencePathWithRefAssemblies)`, just the transport package
    @dougbu
    dougbu committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8b969db View commit details
    Browse the repository at this point in the history

  2. Restore App.Ref exclusions 

    - also remove duplication between `@(AspNetCoreReferenceAssemblyPath)` additions (for efficiency)
    @dougbu
    dougbu committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    1be8200 View commit details
    Browse the repository at this point in the history

  3. !fixup! Correct comments 

    - Crypto.Pkcs is **not** present in the transport package
    @dougbu
    dougbu committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4f94240 View commit details
    Browse the repository at this point in the history