Fixup OpenAPI displayed param type when using TryParse #36526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
old-area-web-frameworks-do-not-use
ghost
added
the
area-mvc
davidfowl
approved these changes
Sep 15, 2021
BrennanConroy
force-pushed
the
brecon/type
branch
from
27d3226 to
23369c7
Compare
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1238663268 |
Contributor
|
@BrennanConroy backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fixup OpenAPI displayed param type when using TryParse
Using index info to reconstruct a base tree...
M src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
M src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
CONFLICT (content): Merge conflict in src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Auto-merging src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fixup OpenAPI displayed param type when using TryParse
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
BrennanConroy
commented
Sep 15, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
FYI, added a nullable primitive type check |
danmoseley
removed
the
old-area-web-frameworks-do-not-use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36412
Before query and path would show object for complex types, now they display string and for primitives we keep them as the primitives name.