Exclude additional types from being validated #37150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent 'System.Delegate' and some reflection types from being validated. Fixes #36919
ghost
added
the
area-mvc
pranavkm
requested review from
a team and
davidfowl
and removed request for
javiercn
pranavkm
commented
Sep 30, 2021
|
|
||
| var visited = validator.ValidationVisitor.Visited; | ||
| Assert.Collection( | ||
| visited, |
Contributor
Author
There was a problem hiding this comment.
Without the change, validation validates about 260k models.
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1292967004 |
Contributor
BrennanConroy
approved these changes
Oct 1, 2021
pranavkm
added a commit
that referenced
this pull request
Oct 1, 2021
Prevent 'System.Delegate' and some reflection types from being validated. Fixes #36919
dougbu
pushed a commit
that referenced
this pull request
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent 'System.Delegate' and some reflection types from being validated.
Fixes #36919