Backport Razor Support ; after @typeparam to 6.0 GA
#37167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
TanayParikh
added
the
Servicing-consider
|
Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
mkArtakMSFT
added
Servicing-approved
mkArtakMSFT
approved these changes
Oct 1, 2021
Contributor
mkArtakMSFT
left a comment
mkArtakMSFT
left a comment
There was a problem hiding this comment.
Signing off as the original PR was already signed off! Thanks @TanayParikh
Contributor
Author
|
@dotnet/aspnet-build could this please be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously users were able to add an optional
;at the end of a@typeparamdirective. In 6.0, this support was regressed. This PR adds back support for an optional closing;.Customer Impact
Prevents a breaking change wherein
@typeparam ISomething;would yield an error in 6.0, where it didn't in 5.0.Regression?
From .NET 5
Risk
Make the compiler more permissive to prevent a breaking change where
;would have no longer be supported after a@typeparamdirective.Verification
Packaging changes reviewed?
Addresses #33602
Backport of: Backport of: #37148