Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IHost being disposed of twice #37631

Closed
wants to merge 2 commits into from
Closed

Fix IHost being disposed of twice #37631

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
721cf1f
Fix IHost being disposed of twice
martincostello Oct 17, 2021
7301823
Do not dispose the host twice
martincostello Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Mvc/Mvc.Testing/src/DeferredHostBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,10 @@ public async ValueTask DisposeAsync()
await disposable.DisposeAsync().ConfigureAwait(false);
return;
}
Dispose();
else
{
_host.Dispose();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a return statement in line 142 so this shouldn't make any difference or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I missed that. In that case, the fix needs to be somewhere else then 🕵️

}
}

public async Task StartAsync(CancellationToken cancellationToken = default)
Expand Down