Skip to content

Unconditionally enable DebBuild and RpmBuild #39644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Jan 20, 2022

  • address a build issue mentioned in dotnet/aspnetcore-internal#3988
  • I accidentally disabled these targets for targeting packs in 08968dd

- address a build issue mentioned in dotnet/aspnetcore-internal#3988
- I accidentally disabled these targets for targeting packs in 08968dd
@dougbu dougbu requested a review from a team January 20, 2022 05:26
@dougbu dougbu requested a review from Pilchie as a code owner January 20, 2022 05:26
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 20, 2022
@dougbu
Copy link
Member Author

dougbu commented Jan 20, 2022

Also included this fix in #39620

@dougbu dougbu merged commit 8bd8f58 into dotnet:main Jan 21, 2022
@dougbu dougbu deleted the dougbu/fix.istargetingpackbuilding.yes.39471 branch January 21, 2022 00:06
@ghost ghost added this to the 7.0-preview1 milestone Jan 21, 2022
ShreyasJejurkar pushed a commit to ShreyasJejurkar/aspnetcore that referenced this pull request Jan 22, 2022
- address a build issue mentioned in dotnet/aspnetcore-internal#3988
- I accidentally disabled these targets for targeting packs in 08968dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants