Avoid modifying the JavaScriptEncoder on SystemTextJsonOutputFormatter #39778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, STJ encodes most non-ASCII characters which is different from Newtonsoft.Json's defaults. When we first defaulted to STJ in 3.1, MVC attempted to minimize this difference by using a more compatible (unsafe-relaxed) encoding scheme if a user hadn't explicitly configured one via JsonOptions. As noted in dotnet#38720, this causes issues if a JsonSerializerContext is configured. This PR changes the output formatter to no longer change the JavaScriptEncoder. Users can manually configure the unsafe-relaxed encoding globally if they understand the consequences of doing so. Contributes to dotnet#38720
ghost
added
the
area-mvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, STJ encodes most non-ASCII characters which is different from Newtonsoft.Json's
defaults. When we first defaulted to STJ in 3.1, MVC attempted to minimize this difference by
using a more compatible (unsafe-relaxed) encoding scheme if a user hadn't explicitly configured one via
JsonOptions.
As noted in #38720, this causes issues if a
JsonSerializerContext is configured. This PR changes the output formatter to no longer
change the JavaScriptEncoder. Users can manually configure the unsafe-relaxed encoding
globally if they understand the consequences of doing so.
Contributes to #38720
{PR title}
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)