Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate Microsoft.Authentication.WebAssembly.Msal for nullability #40269

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Annotate Microsoft.Authentication.WebAssembly.Msal for nullability #40269

merged 1 commit into from
Feb 18, 2022

Conversation

pranavkm
Copy link
Contributor

Contributes to #5680

@pranavkm pranavkm requested review from a team as code owners February 16, 2022 17:36
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Feb 16, 2022
TanayParikh
TanayParikh reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, CI found a few missing areas.

@pranavkm
Copy link
Contributor Author

main is currently bored and is being fixed by #40268. I rebased on that branch, so it should cause this to build, but would show that extra commit

@TanayParikh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@pranavkm
Copy link
Contributor Author

@dotnet/aspnet-build another PR with nullability only changes to PublicAPI.Shipping.txt. Could I get some help getting this merged?

@dougbu dougbu merged commit 68622a8 into dotnet:main Feb 18, 2022
@ghost ghost added this to the 7.0-preview3 milestone Feb 18, 2022
@pranavkm pranavkm deleted the add-nulls branch February 18, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanayParikh TanayParikh TanayParikh approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
7.0-preview3
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @TanayParikh @dougbu