Enable CA1810 as a warning #40384
Merged
Enable CA1810 as a warning #40384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
added
the
area-infrastructure
Contributes to dotnet#24055
pranavkm
requested review from
BrennanConroy,
halter73,
Tratcher,
javiercn and
Pilchie
as code owners
pranavkm
commented
Feb 24, 2022
| using System.Diagnostics; | ||
| using Microsoft.Extensions.Logging; | ||
|
|
||
| namespace Microsoft.AspNetCore.Mvc.Razor; |
There was a problem hiding this comment.
Nearly all of the log messages on this types, except the one you see in the previous file, had been moved to individual types over time, and hence weren't referenced.
| @@ -2,6 +2,7 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| #nullable disable | |||
| #pragma warning disable CA1810 // Initialize all static fields inline. | |||
There was a problem hiding this comment.
I'll try and do do this separately. The source generator does not like that we reuse ids.
| $"{nameof(ResourceManagerStringLocalizer)} searched for '{{Key}}' in '{{LocationSearched}}' with culture '{{Culture}}'."); | ||
| } | ||
|
|
||
| public static void SearchedLocation(this ILogger logger, string key, string searchedLocation, CultureInfo culture) |
There was a problem hiding this comment.
Moved this to ResourceManagerStringLocalizer in the file below.
| @@ -53,5 +38,15 @@ static Diagnostics() | |||
| DiagnosticSeverity.Warning, | |||
| isEnabledByDefault: true, | |||
| helpLinkUri: "https://aka.ms/AA64fv1"); | |||
|
|
|||
| public static readonly ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics = ImmutableArray.Create<DiagnosticDescriptor>(new[] | |||
There was a problem hiding this comment.
Static fields are initialized in the order in which they appear, but you can reference them before they are initialized. Cool new thing I found out today.
BrennanConroy
approved these changes
Feb 25, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #24055
Contributes to #32087