Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize strings in user-jwts tool #42061

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Localize strings in user-jwts tool #42061

merged 2 commits into from
Jun 7, 2022

Conversation

captainsafia
Copy link
Member

  • Adds localizations for string in user-jwts to close dotnet user-jwts follow ups #41820
  • Renames dotnet user-jwts delete to dotnet user-jwts remove
  • Fixes up punctuation on option and argument descriptions

@captainsafia captainsafia added area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-userjwts The `dotnet user-jwts` CLI tool labels Jun 6, 2022
@captainsafia captainsafia requested a review from a team June 6, 2022 22:27
@ghost ghost added the area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI label Jun 6, 2022
@halter73
Copy link
Member

halter73 commented Jun 7, 2022

Do we need a resource string for "The path of the project to operate on. Defaults to the project in the current directory" in ProjectCommandLineApplication?

@captainsafia
Copy link
Member Author

Do we need a resource string for "The path of the project to operate on. Defaults to the project in the current directory" in ProjectCommandLineApplication?

Good catch! Done.

@captainsafia captainsafia merged commit 918f16a into dotnet:main Jun 7, 2022
@ghost ghost added this to the 7.0-preview6 milestone Jun 7, 2022
captainsafia added a commit to captainsafia/aspnetcore that referenced this pull request Jun 13, 2022
@captainsafia
Localize strings in user-jwts tool (dotnet#42061)
cbf0683 
* Localize strings in user-jwts tool

* Update localziations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martincostello martincostello martincostello left review comments

@halter73 halter73 halter73 approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-commandlinetools Includes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPI area-web-frameworks *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels feature-userjwts The `dotnet user-jwts` CLI tool
Projects
None yet
Milestone
7.0-preview6
Development

Successfully merging this pull request may close these issues.

dotnet user-jwts follow ups
3 participants
@captainsafia @halter73 @martincostello