Implementing analyzer to prefer WebApplicationBuilder.Configuration over Configure methods #42351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhthidao
requested review from
Tratcher,
BrennanConroy,
halter73 and
Pilchie
as code owners
|
|
anhthidao
changed the title
anhthidao
changed the title
| "Do not use builder.Host.ConfigureAppConfiguration or builder.Host.ConfigureHostConfiguration", | ||
| "Replace with builder.Configuration", | ||
| "Usage", | ||
| DiagnosticSeverity.Error, |
Co-authored-by: Safia Abdalla <safia@microsoft.com>
… and message. Changing the WebApplicationBuilderAnalyzers class so that the method name can be passed into the diagnostic message
… and message. Changing the WebApplicationBuilderAnalyzers class so that the method name can be passed into the diagnostic message
…otnet/aspnetcore into WebApplicationBuilderAnalyzers
Pilchie
added
the
old-area-web-frameworks-do-not-use
captainsafia
approved these changes
Jun 28, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyzer: Suggest replacing builder.Host.ConfigureAppConfiguration/builder.Host.ConfigureHostConfiguration/builder.WebHost.ConfigureAppConfiguration with builder.Configuration directly
Description
Add analyzers that warns when using ConfigureAppConfiguration/ConfigureHostConfiguration on WebApplicationBuilder.Host/WebApplicationBuilder.WebHost. Suggest switching to builder.Configuration.
Fixes #35815