Allow file middlewares to run if there's an endpoint with a null request delegate #42458
+222
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
DefaultFilesMiddleware
,DirectoryBrowserMiddleware
, andStaticFileMiddleware
to not no-op (fall through to the next middleware in the pipeline) if they detect the request has an active endpoint with a null request delegate.This allows the middleware to run in cases where there's an endpoint with a
null
RequestDelegate
. This enables the ability to have an active endpoint for the purposes of communicating metadata to middleware while allowing middleware like theStaticFileMiddleware
to keep performing its function, e.g. have a "dummy" endpoint to carryIAuthorizeData
metadata so that theAuthorizationMiddleware
performs authorization on a request before theStaticFileMiddleware
runs (example here).Fixes #42413