-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-preview6] Make RateLimitingMiddleware endpoint aware #42471
Closed
github-actions
wants to merge
22
commits into
release/7.0-preview6
from
backport/pr-42417-to-release/7.0-preview6
Closed
[release/7.0-preview6] Make RateLimitingMiddleware endpoint aware #42471
github-actions
wants to merge
22
commits into
release/7.0-preview6
from
backport/pr-42417-to-release/7.0-preview6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Tratcher,
BrennanConroy,
a team,
dougbu and
wtgodbe
as code owners
June 28, 2022 17:03
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Blocked on #42358 since that ingests API changes from dotnet/runtime |
rbhanda
added
Servicing-approved
Shiproom has approved the issue
and removed
Servicing-consider
Shiproom approval is required for the issue
labels
Jun 28, 2022
Closing in favor of #42358 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42417 to release/7.0-preview6
/cc @wtgodbe
{PR title}
Make RateLimitingMiddleware endpoint aware
Description
Allows usage of the RateLimitingMiddleware to apply rate limits to endpoints more easily - adds API from the issue below
Fixes #41667
Customer Impact
Fleshes out the RateLimitingMiddleware feature we're adding in net7.0, makes it easier to use and more customizable. We'd like to get this in for preview6 to give more time for feedback.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This is coming in hot, so there may be bugs we haven't caught yet.
Verification
Packaging changes reviewed?
When servicing release/2.1