Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-preview6] Make RateLimitingMiddleware endpoint aware #42471

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 28, 2022

Backport of #42417 to release/7.0-preview6

/cc @wtgodbe

{PR title}

Make RateLimitingMiddleware endpoint aware

Description

Allows usage of the RateLimitingMiddleware to apply rate limits to endpoints more easily - adds API from the issue below

Fixes #41667

Customer Impact

Fleshes out the RateLimitingMiddleware feature we're adding in net7.0, makes it easier to use and more customizable. We'd like to get this in for preview6 to give more time for feedback.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

This is coming in hot, so there may be bugs we haven't caught yet.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

@wtgodbe wtgodbe added the Servicing-consider Shiproom approval is required for the issue label Jun 28, 2022
@ghost
Copy link

ghost commented Jun 28, 2022

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@wtgodbe
Copy link
Member

wtgodbe commented Jun 28, 2022

Blocked on #42358 since that ingests API changes from dotnet/runtime

@rbhanda rbhanda added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jun 28, 2022
@wtgodbe
Copy link
Member

wtgodbe commented Jun 28, 2022

Closing in favor of #42358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants