Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blazor] Obsolete InvokeUnmarshalled #42814

Merged
merged 4 commits into from
Jul 20, 2022
Merged

[blazor] Obsolete InvokeUnmarshalled #42814

merged 4 commits into from
Jul 20, 2022

Conversation

pavelsavara
Copy link
Member

  • obsolete InvokeUnmarshalled
  • [JSImport] only in WebAssemblyConsoleLogger as POC
  • hotfix for binding initialization in blazor's custom startup sequence

@pavelsavara pavelsavara added area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly labels Jul 19, 2022
@pavelsavara pavelsavara added this to the 7.0-rc1 milestone Jul 19, 2022
@pavelsavara pavelsavara self-assigned this Jul 19, 2022
@pavelsavara pavelsavara requested a review from a team as a code owner July 19, 2022 17:51
@pavelsavara pavelsavara mentioned this pull request Jul 19, 2022
Closed
@SteveSandersonMS
Copy link
Member

This is great. Thanks @pavelsavara! Just a few minor tweaks and I expect we can merge this today.

pavelsavara and others added 3 commits July 20, 2022 15:18
@pavelsavara @SteveSandersonMS
Update src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.W…
68b51ab 
…ebAssembly.csproj

Co-authored-by: Steve Sanderson <SteveSandersonMS@users.noreply.github.com>
@pavelsavara
feedback
2a320e7
@pavelsavara
feedback
5995535
@SteveSandersonMS SteveSandersonMS self-requested a review July 20, 2022 14:02
SteveSandersonMS
SteveSandersonMS approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pavelsavara!

@pavelsavara pavelsavara merged commit e6f27b0 into dotnet:main Jul 20, 2022
@guardrex guardrex mentioned this pull request Sep 12, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

@pavelsavara pavelsavara

Labels
area-blazor Includes: Blazor, Razor Components feature-blazor-wasm This issue is related to and / or impacts Blazor WebAssembly
Projects
None yet
Milestone
7.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @SteveSandersonMS