Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated jquery dependency to v3.6.0 #43060

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Updated jquery dependency to v3.6.0 #43060

merged 2 commits into from
Aug 4, 2022

Conversation

mkArtakMSFT
Copy link
Member

Addresses #42815

@mkArtakMSFT mkArtakMSFT added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 3, 2022
@ghost
Copy link

ghost commented Aug 3, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@mkArtakMSFT mkArtakMSFT linked an issue Aug 3, 2022 that may be closed by this pull request
jQuery License outdated #42815
Closed
1 task
wtgodbe
wtgodbe approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the NPM parts

@mkArtakMSFT mkArtakMSFT requested a review from ChrisSfanos August 4, 2022 19:40
@mkArtakMSFT
Copy link
Member Author

Thanks @wtgodbe.
@ChrisSfanos, can you please sign-off on the license change?

ChrisSfanos
ChrisSfanos approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@ChrisSfanos ChrisSfanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with this change

@mkArtakMSFT mkArtakMSFT merged commit bc3a2dd into main Aug 4, 2022
@mkArtakMSFT mkArtakMSFT deleted the mkArtakMSFT/jQuery branch August 4, 2022 21:26
@ghost ghost added this to the 7.0-rc1 milestone Aug 4, 2022
@mkArtakMSFT mkArtakMSFT mentioned this pull request Sep 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@ChrisSfanos ChrisSfanos ChrisSfanos approved these changes

@adityamandaleeka adityamandaleeka Awaiting requested review from adityamandaleeka

@HaoK HaoK Awaiting requested review from HaoK

@rafikiassumani-msft rafikiassumani-msft Awaiting requested review from rafikiassumani-msft

@Tratcher Tratcher Awaiting requested review from Tratcher

@Pilchie Pilchie Awaiting requested review from Pilchie

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-rc1
Development

Successfully merging this pull request may close these issues.

jQuery License outdated
3 participants
@mkArtakMSFT @ChrisSfanos @wtgodbe