Skip to content

Follow-up for cancellation of navigation events in Blazor #43079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

MackinnonBuck
Copy link
Member

Follow-up for cancellation of navigation events in Blazor

This PR applies the changes discussed in the API review issue #42877.

Description

Functionality remains almost completely the same as it did before, but now the API has changed in accordance with the API review for this feature. I'll point out any differences in behavior by commenting on this PR.

Fixes #42877

@MackinnonBuck MackinnonBuck requested a review from a team as a code owner August 3, 2022 19:52
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Aug 3, 2022
Co-authored-by: campersau <buchholz.bastian@googlemail.com>
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

I added a couple of minor suggestions but besides that I think this feature looks all wrapped up :)

@MackinnonBuck MackinnonBuck merged commit 80ea573 into main Aug 4, 2022
@MackinnonBuck MackinnonBuck deleted the mbuck/navigation-cancellation-follow-up branch August 4, 2022 19:23
@ghost ghost added this to the 7.0-rc1 milestone Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blazor] Enable cancellation of navigation events
4 participants