Sync output cache with API review #43121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sebastienros
commented
Aug 9, 2022
| builder.Append(KeyDelimiter) | ||
| .Append(routeValueName) | ||
| .Append('=') | ||
| .Append(Convert.ToString(routeValueValue, CultureInfo.InvariantCulture)); |
There was a problem hiding this comment.
A route value is an object as opposed to headers and queries. I think we need to force the culture here for normalize the key.
sebastienros
commented
Aug 9, 2022
sebastienros
commented
Aug 9, 2022
| @@ -46,15 +46,13 @@ ValueTask IOutputCachePolicy.ServeResponseAsync(OutputCacheContext context, Canc | |||
| // Verify existence of cookie headers | |||
| if (!StringValues.IsNullOrEmpty(response.Headers.SetCookie)) | |||
| { | |||
| context.Logger.ResponseWithSetCookieNotCacheable(); | |||
There was a problem hiding this comment.
Removed logs from this policy as it requires the logger to be resolved (on each request?) and also because further policies can negate the results here and the lot would be wrong.
davidfowl
reviewed
Aug 10, 2022
halter73
reviewed
Aug 11, 2022
JamesNK
reviewed
Aug 11, 2022
wtgodbe
reviewed
Aug 15, 2022
| var varyByPrefix = context.CacheVaryByRules.VaryByPrefix; | ||
|
|
||
| // Check if any vary rules exist | ||
| if (!StringValues.IsNullOrEmpty(varyHeaders) || !StringValues.IsNullOrEmpty(varyQueryKeys) || !StringValues.IsNullOrEmpty(varyByPrefix) || varyByCustomKeys?.Count > 0) | ||
| if (!StringValues.IsNullOrEmpty(varyHeaderNames) || !StringValues.IsNullOrEmpty(varyRouteValueNames) || !StringValues.IsNullOrEmpty(varyQueryKeys) || !StringValues.IsNullOrEmpty(varyByPrefix) || varyByCustomKeys?.Count > 0) |
There was a problem hiding this comment.
This line is pretty long, may be better to wrap it
There was a problem hiding this comment.
I have another PR that will remove it, so I will ignore it for now (if I may).
amcasey
added
the
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying API review feedback, and adding anticipated changes from new one