Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Set MSBUILDLOGALLENVIRONMENTVARIABLES in most CI jobs #43644

Merged
merged 1 commit into from
Aug 31, 2022
Merged

[release/7.0] Set MSBUILDLOGALLENVIRONMENTVARIABLES in most CI jobs #43644

merged 1 commit into from
Aug 31, 2022

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Aug 30, 2022

  • should affect most of our pipelines though not a few post-build jobs
  • as we saw in Update SDK #43028, binary logs no longer include all environment variables by default
    • this change captures the environment variables not visibly referenced in our projects etc.
    • fix avoids a need to add the override later to debug an issue, at the cost of larger .binlog files

@dougbu
[release/7.0] Set MSBUILDLOGALLENVIRONMENTVARIABLES in most CI jobs
ce331fc 
- should affect most of our pipelines though not a few post-build jobs
- as we saw in dotnet#43028, binary logs no longer include all environment variables by default
  - this change captures the environment variables not visibly referenced in our projects etc.
  - fix avoids a need to add the override later to debug an issue, at the cost of larger .binlog files
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Aug 30, 2022
@dougbu dougbu requested review from a team and wtgodbe as code owners August 30, 2022 23:53
@ghost
Copy link

ghost commented Aug 30, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Member Author

dougbu commented Aug 30, 2022

/fyi @rainersigwald @Forgind and @baronfel

@dougbu dougbu mentioned this pull request Aug 30, 2022
Merged
@dougbu dougbu merged commit 6b02007 into dotnet:release/7.0 Aug 31, 2022
@dougbu dougbu deleted the dougbu/expand.binary.logging branch August 31, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@Forgind Forgind Forgind approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougbu @Forgind @wtgodbe