Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn HTTP/3 on by default in Kestrel #44217

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Turn HTTP/3 on by default in Kestrel #44217

merged 2 commits into from
Oct 4, 2022

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 28, 2022

Fixes #36486

@Tratcher
Copy link
Member

Tratcher commented Sep 28, 2022

Should we try to fix #41762 first? Will devs get errors if they try this and the cert doesn't work? Or will it fall back silently?

@JamesNK
Copy link
Member Author

JamesNK commented Sep 28, 2022

It falls back silently.

@JamesNK JamesNK merged commit 43c935b into main Oct 4, 2022
@JamesNK JamesNK deleted the jamesnk/http3-defaulton branch October 4, 2022 06:42
@ghost ghost added this to the 8.0-preview1 milestone Oct 4, 2022
@JamesNK JamesNK added the blog-candidate Consider mentioning this in the release blog post label Feb 10, 2023
@ghost
Copy link

ghost commented Feb 10, 2023

@JamesNK, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work!

Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers.

This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement.

Thanks!

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
@Eagle3386
Copy link

@JamesNK I'm a bit confused: while it does state Merged into main since almost a year ago, even the current main-branch as of now still hasn't enabled HTTP/3 in Kestrel by default:

internal const HttpProtocols DefaultHttpProtocols = HttpProtocols.Http1AndHttp2;

Furthermore, if I explicitly go to the commit's "branch", it reads as follows:

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Therefore, I'd like to know what happened & what's the plan for going forward with Kestrel & "HTTP/3 on by default"?

@JamesNK
Copy link
Member Author

JamesNK commented Sep 26, 2024

It was later turned off by default because anti-virus would always prompt for HTTP/3 endpoints.

You can still configure Kestrel to turn HTTP/3 on if you want to use it.

@Eagle3386
Copy link

Thanks, but are there plans to re-enable this by default at some future point (.NET 9/10) or will it remain like it's now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions blog-candidate Consider mentioning this in the release blog post
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP/3: Enable in Kestrel by default
4 participants