-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add schema in launchSettings.json files #44295
Conversation
I'm not sure if this is the right approach. Change to the VS code extension for that: dotnet/vscode-csharp#4280. There was a similar change in VS. Do we want the schema added to these files, or should it be consistent with what |
@JamesNK it's nice that the tooling can infer the schema, but I don't think it's contradicting this PR. If someone uses another tool, let's say Rider, or VS for MAC (not sure it does it too). And assuming adding the schema in the templates don't conflict with the tooling. One template already had the reference, so if we decide to not add the schema then I will remove it from there ( Line 2 in 9127115
In any case we can also ponder if launchSettings support should be added to tooling too. |
Another thing to consider is the schema file that VS generates if one isn't present. I tested deleting the file and restarting VS, and the newly generated launchSettings.json doesn't have a $schema property. |
Yeah, I think so. Although it sounds like one launchSettings.json is specifying the schema. Remove it from that one for consistency? |
Found 4 files with it, 2 sample and 2 templates |
@JamesNK GTG? |
@dotnet/aspnet-build please merge |
Fixes #38120
Complementary to SchemaStore/schemastore#2507