-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project template precedence values #44479
Conversation
src/ProjectTemplates/Web.Client.ItemTemplates/content/Scss/.template.config/template.json
Show resolved
Hide resolved
Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
UPDATE: There is some discussion offline about the general direction we should take with the template configuration. Let's hold off merging until that conversation concludes. |
I think we're ready to merge this. Agreed @MackinnonBuck❔ If yes, remove |
I agree, let's merge this. Thanks! |
Update project template precedence values
When .NET 6 and .NET 7 are installed side-by-side, some item templates cannot be created via
dotnet new
. This PR fixes the issue by giving the 7.0 templates higher precedence.Description
Attempting to run
dotnet new
using one of the affected project templates (e.g. "page") results in the following error:The fix is to update the "precedence" values for each template to correlate with the major version (e.g.
700
for .NET 7).Customer Impact
Without this fix, customers would not be able to use
dotnet new
with any of the templates defined inWeb.ItemTemplates
orWeb.Client.ItemTemplates
if .NET 6 and .NET 7 are installed side-by-side.Regression?
This is a new bug that occurs when .NET 6 and .NET 7 are installed side-by-side.
Risk
This PR changes a single value for each affected template configuration. We've already updated the precedence values for other templates and haven't seen any problems arise from that change.
Verification
Packaging changes reviewed?