-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates] Fix links to http://useiconic.com #44597
Conversation
Hi @javiercn. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
src/Components/Samples/BlazorServerApp/wwwroot/css/open-iconic/README.md
Outdated
Show resolved
Hide resolved
b74aff0
to
7abbb1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a stopgap measure this works for me
@blowdart , @javiercn I wonder if for the link we should use the suggestion from iconic/open-iconic#60 (comment) instead?
|
I think that's worse, as we're relying on another 3rd party caching a 3rd party. While I generally trust archive.org page copyright owners can get things removed. The best option would be update the whole thing, icons, readme, license. If we can't get into 7.0 rtm then we have more time and that's the way to go, this is just a tactical option right now. |
Note this also exists in dotnet/samples, dotnet/maui-samples, dotnet/blazor-samples, dotnet/aspnetcore.docs. I guess those don't need updating on the GA timeline though. |
The original links are to "useiconic.com" not "useionic.com". Ionic is a product that happens to have its own set of icons, but I don't think it's related to Iconic or open iconic, which is what we use. I don't think we should be replacing links to Iconic with links to Ionic icons (ionicons). Maybe just remove the links to useiconic.com for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue covering remaining work: #44606 |
I think that the website has changed to: https://www.appstudio.dev/app/OpenIconic.html. This new site features the same number of icons, 223, and same licenses as were found at the previous site (useiconic.com/open). |
Hi @masterparser. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Updates links to point to up-to-date documentation
Description
Updates the links in the readme.md of one of our template files to point out to the newer documentation site.
Customer Impact
Customers who will read this doc will have valid links to use for getting to the icons.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
It is updating a file in the templates that doesn't affect how the project is built or runs, only documentation.
Verification
Packaging changes reviewed?