Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging internal commits for release/7.0 #44949

Merged

Conversation

vseanreesermsft
Copy link
Contributor

No description provided.

- update baselines to 7.0.0 release
  - start from <https://dev.azure.com/dnceng/_apis/resources/Containers/12084037/BlobArtifacts?itemPath=BlobArtifacts%2FMergedManifest.xml>
  - picks up all dropped and added packages in 7.0.0
- enable baseline validation
- update the .NET SDK to the GA version
- update site extension versions
- correct a typo in `$(DotNetPrivateAssetRootUrl)` value
@dougbu dougbu force-pushed the internal-merge-7.0-2022-11-08-1118 branch from b18673a to 2ebaa4c Compare November 9, 2022 06:41
@dougbu
Copy link
Member

dougbu commented Nov 9, 2022

/fyi @vseanreesermsft something went wrong w/ your merge commit. I had to redo the merge to clear corruption in ci.yml

@dougbu
Copy link
Member

dougbu commented Nov 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dougbu
Copy link
Member

dougbu commented Nov 9, 2022

@mmitche is there documentation on the DownloadFile task somewhere❔ I don't know how to fill the described gap.

src\Framework\App.Runtime\src\Microsoft.AspNetCore.App.Runtime.csproj(514,5): error MSB4096: (NETCORE_ENGINEERING_TELEMETRY=Build) The item "https://dotnetcli.azureedge.net/dotnet/Runtime/7.0.0-rtm.22518.5/dotnet-runtime-7.0.0-win-arm.zip" in item list "UrisToDownload" does not define a value for metadata "DotNetRuntimeArchive".  In order to use this metadata, either qualify it by specifying %(UrisToDownload.DotNetRuntimeArchive), or ensure that all items in this list define a value for this metadata

@dougbu
Copy link
Member

dougbu commented Nov 9, 2022

Thanks @mmitche I was just about to push exactly the same !fixup! commit 😁

mmitche and others added 3 commits November 9, 2022 14:16
- get logs for most CI jobs (not Code Check or Helix x64)
- was still trying to use our version
@dougbu dougbu force-pushed the internal-merge-7.0-2022-11-08-1118 branch from 45e298a to 2dea6cd Compare November 9, 2022 23:50
- don't try internal download location in public builds
- use two targets to make Product.targets more readable
@mmitche
Copy link
Member

mmitche commented Nov 10, 2022

We've been seeing this AbandonedMutexException quite a bit in the aspnet PRs. It smells bad to me. @zivkan does this look familiar to you at all? This PR includes an upgrade to the RTM build of .NET

  Determining projects to restore...
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: The "RestoreTask" task failed unexpectedly. [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) The "RestoreTask" task failed unexpectedly. [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: System.Threading.AbandonedMutexException: The wait completed due to an abandoned mutex. [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) System.Threading.AbandonedMutexException: The wait completed due to an abandoned mutex. [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: at System.Threading.WaitHandle.WaitOneNoCheck(Int32 millisecondsTimeout) [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at System.Threading.WaitHandle.WaitOneNoCheck(Int32 millisecondsTimeout) [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: at NuGet.Common.Migrations.MigrationRunner.Run() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at NuGet.Common.Migrations.MigrationRunner.Run() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: at NuGet.Build.Tasks.RestoreTask.Execute() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at NuGet.Build.Tasks.RestoreTask.Execute() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]
/mnt/vss/_work/1/s/.dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj] [/mnt/vss/_work/1/s/.packages/microsoft.dotnet.arcade.sdk/7.0.0-beta.22513.4/tools/Tools.proj]
##[error].dotnet/sdk/7.0.100/NuGet.targets(132,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Restore) at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) [/tmp/0a9fc532-050c-4a94-87ad-363e4687f8ce/restore.csproj]

@wtgodbe
Copy link
Member

wtgodbe commented Nov 10, 2022

@mmitche #45001, #44741

@mmitche
Copy link
Member

mmitche commented Nov 10, 2022

WOOHOO!

@ghost
Copy link

ghost commented Nov 10, 2022

Hi @mmitche. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@zivkan
Copy link
Member

zivkan commented Nov 10, 2022

NuGet has a fix for the abandoned mutex exception: NuGet/Home#12159
We're in the process of trying to service all the supported versions.

@ghost
Copy link

ghost commented Nov 10, 2022

Hi @zivkan. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@dougbu dougbu added this to the 7.0.1 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants