Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Use simpler Docker tags #45115

Merged

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 15, 2022

  • cherry-pick of 5f4bc82, Update docker tag to latest schema
  • cherry-pick of f79f2d1, Replace -latest docker tags with new schema
    • We changed the latest tags to not include the -latest suffix, so this change updates those tags to the new schema.

nit: Correct timeout of source-build job

  • not honoured as a top-level parameter to source-build.yml

- `cherry-pick` of 5f4bc82, Update docker tag to latest schema
  - This change moves all of the docker images to the -latest tag as part of dotnet#10377.
- `cherry-pick` of f79f2d1, Replace -latest docker tags with new schema
  - We changed the latest tags to not include the -latest suffix, so this change updates those tags to the new schema.

nit: Correct timeout of source-build job
- not honoured as a top-level parameter to source-build.yml
@dougbu dougbu requested review from a team and wtgodbe as code owners November 15, 2022 19:56
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 15, 2022
dougbu pushed a commit to dougbu/aspnetcore that referenced this pull request Nov 15, 2022
- `cherry-pick` of 5f4bc82, Update docker tag to latest schema
  - This change moves all of the docker images to the -latest tag as part of dotnet#10377.
- `cherry-pick` of f79f2d1, Replace -latest docker tags with new schema
  - We changed the latest tags to not include the -latest suffix, so this change updates those tags to the new schema.
- via dotnet#45115, w/ a slight adjustment from rhel-7 to centos-7 in rhel.Dockerfile

nit: Correct timeout of source-build job
- not honoured as a top-level parameter to source-build.yml
@dougbu dougbu added the tell-mode Indicates a PR which is being merged during tell-mode label Nov 15, 2022
mmitche pushed a commit that referenced this pull request Nov 15, 2022
- `cherry-pick` of 5f4bc82, Update docker tag to latest schema
  - This change moves all of the docker images to the -latest tag as part of #10377.
- `cherry-pick` of f79f2d1, Replace -latest docker tags with new schema
  - We changed the latest tags to not include the -latest suffix, so this change updates those tags to the new schema.
- via #45115, w/ a slight adjustment from rhel-7 to centos-7 in rhel.Dockerfile

nit: Correct timeout of source-build job
- not honoured as a top-level parameter to source-build.yml

Co-authored-by: Michelle McDaniel <michelm@microsoft.com>
@mmitche mmitche merged commit 26e3dfc into dotnet:release/7.0 Nov 15, 2022
@dougbu dougbu deleted the dougbu/backport.Helix.queue.changes branch November 16, 2022 02:46
@dougbu dougbu added this to the 7.0.1 milestone Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants