Avoid allocations from getting JsonOptions in Minimal #45359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
Perf
old-area-web-frameworks-do-not-use
ghost
added
the
davidfowl
reviewed
Nov 30, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
davidfowl
approved these changes
Nov 30, 2022
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
What was the offending code that was the source of the allocations? Is it related to getting options from DI per request? |
|
|
Ok! I didn't know resolving config types from DI allocated. Usually, getting config from DI isn't on the hot path. |
JamesNK
reviewed
Dec 1, 2022
JamesNK
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #45330
Removes the two DI allocations and
RequestServicesallocation seen in #45330 (comment) which reduces the allocation rate of the JsonMapAction benchmark from 307M bytes/sec to 160M bytes/sec as well as increasing the RPS from from 845k to 894k.We don't really have any E2E tests for RequestDelegateFactory, at least none that I could find. Fortunately, we do hit the code paths that were changed so it was easy to find all the Expression Tree code that I needed to update (follow the exceptions from tests).
Bonus: Updated the read path as well, so it'll be faster for Json requests.