Use built in methods #45426
Merged
Use built in methods #45426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
requested review from
a team,
Tratcher,
BrennanConroy and
halter73
as code owners
adamsitnik
force-pushed
the
useBuiltInMethods
branch
from
40be5ad to
c7ca6cb
Compare
adamsitnik
force-pushed
the
useBuiltInMethods
branch
from
c7ca6cb to
9cb6483
Compare
BrennanConroy
approved these changes
Dec 2, 2022
adityamandaleeka
approved these changes
Dec 3, 2022
skundlony
approved these changes
Dec 4, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While searching for potential usages for new ASCII APIs (dotnet/runtime#28230) I've found few places where we could use existing built-in methods.
IndexOfAnyExceptInRangeis vectorized and should provide perf improvements for larger inputs. It requires .NET 8, I am hoping that this repo is already targeting it. If not, I am going to close the PR and re-open it when it does.