Skip to content

Skip Source Build for now #46190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

Skip Source Build for now #46190

merged 1 commit into from
Jan 20, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 20, 2023 •
edited
Loading

Source Build failures are blocking CI & Official builds until dotnet/source-build#3111 is resolved - let's skip that job until it's fixed

Related - #46191

@wtgodbe wtgodbe requested review from a team and dougbu as code owners January 20, 2023 18:17
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 20, 2023
dougbu
dougbu approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It doesn't matter that much, but we don't usually check in commented-out or unreachable code. Could have just deleted the job and reverted the commit when the bug is fixed.

@wtgodbe wtgodbe mentioned this pull request Jan 20, 2023
Closed
@wtgodbe wtgodbe enabled auto-merge (squash) January 20, 2023 18:22
@wtgodbe wtgodbe merged commit c77deeb into main Jan 20, 2023
@wtgodbe wtgodbe deleted the wtgodbe/SkipSB branch January 20, 2023 20:08
@ghost ghost added this to the 8.0-preview1 milestone Jan 20, 2023
@eerhardt eerhardt mentioned this pull request Jan 23, 2023
Merged
wtgodbe added a commit that referenced this pull request Jan 24, 2023
@wtgodbe
Revert "Skip Source Build for now (#46190)"
df4c6fb 
This reverts commit c77deeb.
wtgodbe added a commit that referenced this pull request Jan 24, 2023
@dotnet-maestro @wtgodbe
[main] Update dependencies from dotnet/arcade (#46248)
c31b892 
* Update dependencies from https://github.com/dotnet/arcade build 20230123.10

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 8.0.0-beta.23067.5 -> To Version 8.0.0-beta.23073.10

* Revert "Don't depend on source-build job while it isn't running (#46220)"

This reverts commit 7369057.

* Revert "Skip Source Build for now (#46190)"

This reverts commit c77deeb.

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: wtgodbe <wigodbe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@wtgodbe @sebastienros @dougbu