Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Avoid stream ID and client result ID collisions #46591

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 11, 2023

Backport of #46570 to release/7.0

/cc @BrennanConroy

Avoid stream ID and client result ID collisions

Description

The new Client Results features in 7.0 can cause a conflict with the Client Streaming feature in very specific cases. Specifically, when the client and server generate the same ID and then the client returns a result, which will complete the stream instead of completing the client result.

Fixes #46503

Customer Impact

In rare cases client to server streams can be completed accidentally and client results will end up timing out.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Narrow scope, combination of new and old feature, well understood issue.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Feb 11, 2023
@ghost ghost added this to the 7.0.x milestone Feb 11, 2023
@ghost
Copy link

ghost commented Feb 11, 2023

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@BrennanConroy BrennanConroy added the Servicing-consider Shiproom approval is required for the issue label Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@BrennanConroy BrennanConroy added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Feb 13, 2023
@ghost
Copy link

ghost commented Feb 13, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@BrennanConroy
Copy link
Member

@dotnet/aspnet-build any chance to merge before branch lock down?

@wtgodbe wtgodbe merged commit 691a715 into release/7.0 Feb 14, 2023
@wtgodbe wtgodbe deleted the backport/pr-46570-to-release/7.0 branch February 14, 2023 00:04
@ghost ghost modified the milestones: 7.0.x, 7.0.4 Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants