Add explicit reference to Microsoft.Bcl.AsyncInterfaces in HealthChecks

[MackinnonBuck]

Add explicit reference to Microsoft.Bcl.AsyncInterfaces in HealthChecks

Addresses #46683 by adding an explicit reference to Microsoft.Bcl.AsyncInterfaces from Microsoft.Extensions.Diagnostics.HealthChecks when the target framework is netstandard2.0.

Opening initially as a draft PR to gather feedback.

[dougbu]

@JamesNK, @BrennanConroy, @captainsafia you've all made HealthChecks changes. But I'm not sure who the current "HealthCheck team members" are. Suggestions for reviewers / discussion participants❔

[captainsafia]

@JamesNK, @BrennanConroy, @captainsafia you've all made HealthChecks changes. But I'm not sure who the current "HealthCheck team members" are. Suggestions for reviewers / discussion participants❔

I think tagging @dotnet/minimal-apis should be good for this area.

[captainsafia]

I think this is read for review. @dougbu @wtgodbe Can you confirm that I've set up the package for automatic updates correctly?

[wtgodbe]

Looks good!

[dougbu]

Agree this change looks good. However, it's necessary but not sufficient. Need to check projects for transitive dependencies (perhaps searching project.assets.json or *.deps.json files) for Microsoft.Bcl.* references that aren't explicit in the corresponding *.csproj files. That is, we need to find other indirect references that should be made direct. Doesn't have to be w/in this PR of course…

[halter73]

I agree with @dougbu that we should automatically detect this issue, but fixing the known issue in the meantime still seems good.

[captainsafia]

I agree with @dougbu that we should automatically detect this issue, but fixing the known issue in the meantime still seems good.

Yeah, I think this should be tracked as a separate infrastructure issue. For the moment, we've addressed the user reported instance.

[dougbu]

I agree with @dougbu that we should automatically detect this issue, but fixing the known issue in the meantime still seems good.

Yeah, I think this should be tracked as a separate infrastructure issue. For the moment, we've addressed the user reported instance.

Agreed, mostly. I wasn't suggesting an ongoing check for indirect references to BCL packages, just a one-time search and another PR.

[captainsafia]

I agree with @dougbu that we should automatically detect this issue, but fixing the known issue in the meantime still seems good.

Yeah, I think this should be tracked as a separate infrastructure issue. For the moment, we've addressed the user reported instance.

Agreed, mostly. I wasn't suggesting an ongoing check for indirect references to BCL packages, just a one-time search and another PR.

I see. I can give this a stab tomorrow.