Flow FullAssemblySigningSupported for source-build to repo tasks #47421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-infrastructure
|
Thanks for your PR, @omajid. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
omajid
force-pushed
the
arcade-source-build-disable-full-signing
branch
from
1146d03 to
dd5fb58
Compare
This property is being added to arcade via dotnet/arcade#12749 and dotnet/arcade#12940 Once this property is added to arcade, it flows correctly to the main aspnetcore build, but not to the build for repo tasks. The repo tasks still need this, otherwise they end up using full signing. Fix that by manually passing the property along (using env var) when building the repo tasks.
omajid
force-pushed
the
arcade-source-build-disable-full-signing
branch
from
dd5fb58 to
2073d1b
Compare
Member
|
@wtgodbe This isn't something I have any context on but it looks reasonable in the diff. Are you able to approve it based on any context you have about this? |
wtgodbe
approved these changes
Mar 30, 2023
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property is being added to arcade via dotnet/arcade#12749 and dotnet/arcade#12940
Once this property is added to arcade, it flows correctly to the main aspnetcore build, but not to the build for repo tasks. The repo tasks still need this, otherwise they end up using full signing.
Fix that by manually passing the property along (using env var) when building the repo tasks.
(Integration tests for this change live in dotnet/installer. Once https://github.com/dotnet/installer/blob/d109cba3ff8ff46fe70be93a40c45002e5770267/eng/pipelines/templates/jobs/vmr-build.yml#L50-L54 is removed, this feature will get exercised end-to-end).