Make HttpLogging middleware endpoint aware #47595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Apr 6, 2023
adityamandaleeka
approved these changes
Apr 7, 2023
|
@BrennanConroy Good to go? |
|
I believe there are analyzers for checking endpoint-aware middleware is between UseRouting and UseEndpoint. Should it be updated to check HttpLogging middleware position? |
halter73
reviewed
Apr 18, 2023
Tratcher
approved these changes
Apr 21, 2023
src/Middleware/HttpLogging/src/HttpLoggingEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
ghost
added this to the 
adityamandaleeka
added
the
blog-candidate
|
@BrennanConroy, this change will be considered for inclusion in the blog post for the release it'll ship in. Nice work! Please ensure that the original comment in this thread contains a clear explanation of what the change does, why it's important (what problem does it solve?), and, if relevant, include things like code samples and/or performance numbers. This content may not be exactly what goes into the blog post, but it will help the team putting together the announcement. Thanks! |
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #43222
And fixes #46703 as it was preventing testing the response byte limit.