[blazor] Boot handled by dotnet.js #47752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
maraf
commented
Apr 17, 2023
•
maraf
commented
- Let runtime handle booting
- Blazor loads boot config only to get dotnet.js URL, before we find a better solution for putting a fingerprint on parts of dotnet.js that change more often
- [browser] Split dotnet.js and introduce loader + emscripten modules runtime#85045
- This PR doesn't migrate some features, that should be considered common and will be done in later PRs
- JSInitializers
- Satelite assemblies
- Lazy assemblies
maraf
added
area-blazor
49 tasks
maraf
requested review from
pavelsavara and
a team
and removed request for
a team
pavelsavara
approved these changes
Apr 20, 2023
| @@ -19,7 +19,7 @@ public class BootResourceCachingTest | |||
| : ServerTestBase<AspNetSiteServerFixture> | |||
| { | |||
| // The cache name is derived from the application's base href value (in this case, '/') | |||
| private const string CacheName = "blazor-resources-/"; | |||
| private const string CacheName = "dotnet-resources-/"; | |||
There was a problem hiding this comment.
This will force one time DLL re-download. I think it's fine.
|
@javiercn any objections, it would be good to get this in soon |
javiercn
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Looks good to me, @MackinnonBuck can you take a look at it too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.