Update SDK

[halter73]

No description provided.

[halter73]

@jjonescz @sharwell @333fred @chsienki After updating the .NET SDK from 8.0.100-preview.5.23257.1 to 8.0.100-preview.5.23265.3, we're seeing errors complaining about async without await in the razor source generator.

/mnt/vss/_work/1/s/src/Identity/UI/src/Microsoft.NET.Sdk.Razor.SourceGenerators/Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator/Areas_Identity_Pages_V5_Account_Manage__Layout_cshtml.g.cs(102,46): error CS1998: This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread. [/mnt/vss/_work/1/s/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj]

Could this be related to dotnet/razor#8346 which was merged last week and was intended to suppress these warnings?

[jjonescz]

@halter73 You're right, that bug fix was wrong in some cases. I opened a follow up to fix this: dotnet/razor#8709

[333fred]

dotnet/razor#8719 was merged, reverting the change here.

[wtgodbe]

dotnet/sdk#32650 brings that change into the SDK. Once that goes in & sdk -> installer flow is done we can grab the new SDK

[wtgodbe]

@eerhardt we're starting to see trimming test failures here

[eerhardt]

I think this looks very similar to dotnet/sdk#32272.

FYI - @nagilson and @sbomer

We could try switching:

aspnetcore/eng/testing/linker/SupportFiles/Directory.Build.props

Line 8 in 7c89649

<PublishSelfContained>true</PublishSelfContained>

to be <SelfContained>true</SelfContained>.

But honestly - I'm not sure I understand the benefit of PublishSelfContained if this scenario doesn't work. FYI - @baronfel @richlander @dsplaisted

[nagilson]

@eerhardt
But honestly - I'm not sure I understand the benefit of PublishSelfContained if this scenario doesn't work. FYI

dotnet/sdk#32277 (comment) This comment should explain the feature a bit better, and I agree with your suggestion.

[javiercn]

@adityamandaleeka can you have someone on your team investigate?

[BrennanConroy]

I don't know anything about this project. @captainsafia is this ok?

[captainsafia]

Yes, this looks correct based on the breaking change details.

[BrennanConroy]

Had to react to the sdk breaking change: dotnet/docs#33726

[mitchdenny]

These checks are green but I'm unsure if this is being held up by anything else? @halter73?