Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Remove IdentityServer from spa-templates #48431

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 25, 2023

Backport of #48430 to release/8.0-preview5

/cc @halter73

Remove IdentityServer from spa-templates

This removes Duende IdentityServer from our angular and react templates and replaces it with default Identity UI and cookie auth.

Fixes #47226

Customer Impact

Customers creating new react or angular projects with "Individual Auth" will instead get the default Identity UI razor pages and cookie auth like they would with an mvc project.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

This is a change to a project template in a preview. It's important to get it out early for customer feedback, but you can always work around any bugs by using the project template from an older release.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@github-actions github-actions bot requested review from a team and wtgodbe as code owners May 25, 2023 17:46
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 25, 2023
@halter73 halter73 added the Servicing-consider Shiproom approval is required for the issue label May 25, 2023
@ghost
Copy link

ghost commented May 25, 2023

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels May 25, 2023
@ghost
Copy link

ghost commented May 25, 2023

Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@wtgodbe wtgodbe merged commit 8bfa496 into release/8.0-preview5 May 25, 2023
@wtgodbe wtgodbe deleted the backport/pr-48430-to-release/8.0-preview5 branch May 25, 2023 20:48
@ghost ghost added this to the 8.0-preview5 milestone May 25, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants