Update WebHostOptions.ShutdownTimeout to 30 seconds #48606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `WebHostOptions.ShutdownTimeout` to 30 seconds to match `Microsoft.Extensions.Hosting.HostOptions.ShutdownTimeout` which was changed to fix [this](dotnet/runtime#63709) issue. fixes 48605
ghost
added
the
community-contribution
|
Thanks for your PR, @hwoodiwiss. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@halter73 can you please review this? Thanks! |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
ghost
added
the
pending-ci-rerun
|
Approving this based on a quick review to see whether this could cause any side effects in existing test cases, and the conversation in the linked issue. |
mitchdenny
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
WebHostOptions.ShutdownTimeoutto 30 secondsUpdates
WebHostOptions.ShutdownTimeoutto 30 seconds to matchMicrosoft.Extensions.Hosting.HostOptions.ShutdownTimeoutDescription
Updates
WebHostOptions.ShutdownTimeoutto 30 seconds to matchMicrosoft.Extensions.Hosting.HostOptions.ShutdownTimeoutwhich was changed to fix this issue.
Fixes #48605