-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ProjectTemplates to Id Web 2.12.2 + MS Graph v5 support #48863
Conversation
… SDK v5. Updates are in project references (from 2.10 to 2.12.2), and new package reference from Microsoft.Identity.Web.MicrosoftGraph to Microsoft.Identity.Web.GraphServiceClient and updates in the respective controllers in graphserviceclient section.
Thanks for your PR, @jennyf19. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The template tests were failing because the new GraphService package was not in the mirrored feeds. I submitted a request to add it to the mirror and am kicking the build to see the results. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@jennyf19 OK -- it looks like test failures related to NuGet packages not being in the mirrored feeds have been resolved. The current failures seem like issues with the template change:
It looks like there might be some other templates that need to be updated to use the correct API? |
Thanks @captainsafia , I thought I had all the Id Web ones. Will take a look. thanks for all your help. |
@@ -0,0 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was inclined to agree with this, and I went as far as to checkout the jennyf19:jennyf/idWebTemplatesUpdate branch and revert 331d122 before merging, only to notice that my VS had automatically created a different launchSettings.json file. I don't think it makes any sense for a Microsoft.NET.Sdk.BlazorWebAssembly project, but it's just going to keep cluttering git's untracked files until we check it in or ignore it.
I'm just going to check it in for now since it seems harmless and I don't want to rekick the build, but we should figure out why VS is generating this. @SteveSandersonMS @dotnet/razor-tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS automatically creating a launchsettings file would be a question for @BillHiebert or @tmeschter I believe. I'm not sure why it necessarily doesn't make sense to have one for a Blazor WASM project though, the project system needs to know what to tell the debugger when people press F5, AFAIK. Maybe things can be changed to not write a default to disk though?
@@ -0,0 +1,12 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was inclined to agree with this, and I went as far as to checkout the jennyf19:jennyf/idWebTemplatesUpdate branch and revert 331d122 before merging, only to notice that my VS had automatically created a different launchSettings.json file. I don't think it makes any sense for a Microsoft.NET.Sdk.BlazorWebAssembly project, but it's just going to keep cluttering git's untracked files until we check it in or ignore it.
I'm just going to check it in for now since it seems harmless and I don't want to rekick the build, but we should figure out why VS is generating this. @SteveSandersonMS @dotnet/razor-tooling
Thanks for the PR @jennyf19, and thanks for mirroring the packages @captainsafia! |
…
Update Id Web ProjectTempates to latest version
Summary of the changes (Less than 80 chars)
Description
Update to the Id Web Project Templates to latest version (2.12.2) which includes support for the new MS Graph SDK v5. Updates are in project references (from 2.10 to 2.12.2), and new package reference from Microsoft.Identity.Web.MicrosoftGraph to Microsoft.Identity.Web.GraphServiceClient and updates in the respective controllers in graphserviceclient section. More information here on the Graph updates. Thank you @surayya-MS and @halter73 for doing the bulk of the work in updating from 1.x to 2.10, much appreciated and unexpected! :)
cc: @captainsafia @Tratcher
Part of issue: AzureAD/microsoft-identity-web#2097