Fix Microsoft.Bcl.AsyncInterfaces references #49716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HealthChecks was missing a reference for net462 - Connections.Abstractions was missing a reference for netstandard2.1 - The DotNetBuildFromSource check was redundant
halter73
requested review from
Tratcher,
BrennanConroy,
JamesNK and
mgravell
as code owners
dotnet-issue-labeler
bot
added
the
area-healthchecks
halter73
added
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
sebastienros
approved these changes
Jul 31, 2023
ghost
added this to the 
No, aspnetcore is the right place for it. See @ericstj's last comment on that issue - the remaining work would be to implement something similar to dotnet/runtime's Package Testing in aspnetcore. It's unlikely I'll have time to get to that any time soon, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed these references were wrong in HealthChecks when merging #42646. Then when I tried to copy the correct usage from the only other place in our repo depending on Microsoft.Bcl.AsyncInterfaces, Connections.Abstractions, I noticed those references were wrong too.
#46683 tracks catching this type of issue automatically. @dotnet/runtime-infrastructure @dotnet/aspnet-build Should we move that issue into the runtime?