-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor Web template updates #49801
Blazor Web template updates #49801
Changes from all commits
450bfba
233af92
ec4f31e
325595b
d001124
9c13f34
f60fba0
f39fb76
1e27e0f
d4efa4b
a0b0c3c
99e8fda
453e15f
029b98b
70c0bf6
3549249
f4c06bf
d3c1e36
b9f2b1c
dae8116
91733d0
4269d5d
d76f3cf
efc27b2
b36c157
9c48280
bf521b4
01a402f
fab438c
e5108c2
306e8f3
25fccb4
9ad0865
d0bf7ed
6832248
f5f7fc9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<Project Sdk="Microsoft.NET.Sdk.BlazorWebAssembly"> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>${DefaultNetCoreTargetFramework}</TargetFramework> | ||
<ImplicitUsings>enable</ImplicitUsings> | ||
<Nullable>enable</Nullable> | ||
<NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> | ||
<StaticWebAssetProjectMode>Default</StaticWebAssetProjectMode> | ||
<RootNamespace Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">BlazorWeb-CSharp.Client</RootNamespace> | ||
<AssemblyName Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">`$(AssemblyName.Replace(' ', '_'))</AssemblyName> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly" Version="${MicrosoftAspNetCoreComponentsWebAssemblyVersion}" /> | ||
</ItemGroup> | ||
|
||
</Project> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
<Project Sdk="Microsoft.NET.Sdk.Web"> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>${DefaultNetCoreTargetFramework}</TargetFramework> | ||
<Nullable>enable</Nullable> | ||
<ImplicitUsings>enable</ImplicitUsings> | ||
<NoDefaultLaunchSettingsFile Condition="'$(ExcludeLaunchSettings)' == 'True'">True</NoDefaultLaunchSettingsFile> | ||
<RootNamespace Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">BlazorWeb-CSharp</RootNamespace> | ||
<AssemblyName Condition="'$(name)' != '$(name{-VALUE-FORMS-}safe_namespace)'">`$(AssemblyName.Replace(' ', '_'))</AssemblyName> | ||
</PropertyGroup> | ||
<!--#if UseWebAssembly --> | ||
|
||
<ItemGroup> | ||
<ProjectReference Include="..\BlazorWeb-CSharp.Client\BlazorWeb-CSharp.Client.csproj" /> | ||
<PackageReference Include="Microsoft.AspNetCore.Components.WebAssembly.Server" Version="${MicrosoftAspNetCoreComponentsWebAssemblyServerVersion}" /> | ||
</ItemGroup> | ||
<!--#endif --> | ||
|
||
</Project> |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,15 +5,16 @@ | |
"longName": "no-restore", | ||
"shortName": "" | ||
}, | ||
"PWA": { | ||
"longName": "pwa", | ||
"isHidden": true | ||
}, | ||
"UseServer": { | ||
"longName": "use-server" | ||
}, | ||
"UseWebAssembly": { | ||
"longName": "use-wasm", | ||
"longName": "use-wasm" | ||
}, | ||
"Empty": { | ||
"longName": "empty" | ||
}, | ||
"IncludeSampleContent": { | ||
Comment on lines
11
to
+17
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not block on this, but we were talking in the past of making The reason we did opt-in as opposed to opt-out was that we didn't have the underlying features in place. Do we want to keep that model (opt-in) or do we want to switch to opt-out. /cc: @danroth27 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dan and I did discuss this and came to the conclusion that server-on-by-default, wasm-off-by-default was the preferred balance for .NET 8. We're certainly free to change that in the future if we so choose. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @javiercn I want interactivity to work by default, but I'm concerned about the complexity that WebAssembly currently adds. I'm thinking about the getting started experience here for new users. Granted, the downside of having WebAssembly off by default is that if you later want to add it, it's not easy to do. |
||
"isHidden": true | ||
}, | ||
"Framework": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other template that we have is
components-webassembly
could we have consistent naming between the two? (EitherBlazorWebassembly
or ComponentsWeb`)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd like to change the other template's name to
BlazorWebAssembly
(to match everything else about its branding) and eliminate the "empty" variant in favour of a flag onBlazorWebAssembly
. Just not trying to do that as part of this PR.