Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Versions.props to latest Microsoft.Identity.Web 2.13.4 #50594

Closed
wants to merge 2 commits into from

Conversation

jmprieur
Copy link
Contributor

@jmprieur jmprieur commented Sep 8, 2023

Update Versions.props to latest Microsoft.Identity.Web 2.13.4

This makes sure the Microsoft Entra External ID scenarios work well with ASP.NET Core in .NET 8 rc2

@jmprieur jmprieur requested review from wtgodbe and a team as code owners September 8, 2023 17:19
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 8, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 8, 2023
@ghost
Copy link

ghost commented Sep 8, 2023

Thanks for your PR, @jmprieur. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost
Copy link

ghost commented Sep 8, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 18, 2023

I don't know what's up with the test failures here, the same thing worked in main: #50582

@wtgodbe
Copy link
Member

wtgodbe commented Sep 18, 2023

@MackinnonBuck can you take a look at the test failures?

@ghost
Copy link

ghost commented Sep 26, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 26, 2023
@MackinnonBuck
Copy link
Member

/azp run

@ghost ghost removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 26, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MackinnonBuck
Copy link
Member

Each of the failures mentions package downgrades. For example:

error NU1605: Warning As Error: Detected package downgrade: Microsoft.AspNetCore.Authentication.JwtBearer from 8.0.0-preview.7.23375.9 to 8.0.0-ci. Reference the package directly from the project to select a different version.

Not sure why this didn't happen in #50582. @halter73 do you know what might be going on?

@ghost
Copy link

ghost commented Oct 4, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Oct 4, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Nov 13, 2023

Superseded by #51430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants