Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestQuery logging bug fix #50767

Merged
merged 1 commit into from
Sep 20, 2023
Merged

RequestQuery logging bug fix #50767

merged 1 commit into from
Sep 20, 2023

Conversation

onurkanbakirci
Copy link
Contributor

RequestQuery logging bug

Fix of 50487

Description

| HttpLoggingFields.RequestQuery added

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware label Sep 18, 2023
@ghost ghost added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member labels Sep 18, 2023
@ghost
Copy link

ghost commented Sep 18, 2023

Thanks for your PR, @onurkanbakirci. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

amcasey
amcasey approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool to add a test, but the change LGTM.

@adityamandaleeka adityamandaleeka merged commit dedac87 into dotnet:main Sep 20, 2023
26 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Sep 20, 2023
@adityamandaleeka
Copy link
Member

Thanks @onurkanbakirci

@adityamandaleeka adityamandaleeka mentioned this pull request Sep 20, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amcasey amcasey amcasey approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

@adityamandaleeka adityamandaleeka

Labels
area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlesware area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@onurkanbakirci @adityamandaleeka @amcasey