Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quarantine CanLaunchPhotinoWebViewAndClickButton #50803

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Quarantine CanLaunchPhotinoWebViewAndClickButton #50803

merged 2 commits into from
Sep 21, 2023

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Sep 19, 2023 •
edited by SteveSandersonMS
Loading

Update: See #50802

@halter73 halter73 requested a review from Eilon September 19, 2023 01:49
@halter73 halter73 requested a review from a team as a code owner September 19, 2023 01:49
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Sep 19, 2023
@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Sep 19, 2023 •
edited
Loading

@halter73 Can you add the rest of the quarantine issue template here so we know, e.g., what the failing build was?

I've been searching though the recent builds, and looking at the test failure report, and didn't spot any case where this test failed so am unclear on why it's being quarantined.

@SteveSandersonMS
Copy link
Member

Please don't merge until this PR is updated to explain its reasoning.

@Eilon Eilon self-requested a review September 19, 2023 16:37
@Eilon
Copy link
Member

Eilon commented Sep 19, 2023

Yeah I don't exactly understand when/how this failed. It's clearly a failure on the links but I don't recall this test failing once I finished working on it...

@SteveSandersonMS
Copy link
Member

It's clearly a failure on the links

What is the "links"? Can you link to a failing build?

@Eilon
Copy link
Member

Eilon commented Sep 19, 2023

It's clearly a failure on the links

What is the "links"? Can you link to a failing build?

@SteveSandersonMS there are links in here: #50802

But I don't understand what build those are from because the tests of course passed on my PR. Are these AzDO builds from a regular "nightly" build or something that runs independently of PRs?

@halter73 halter73 enabled auto-merge (squash) September 19, 2023 21:22
@halter73
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@halter73 halter73 merged commit e6c7c01 into main Sep 21, 2023
23 of 26 checks passed
@halter73 halter73 deleted the halter73/50802 branch September 21, 2023 00:51
@ghost ghost added this to the 9.0-preview1 milestone Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@Eilon Eilon Awaiting requested review from Eilon

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@halter73 @SteveSandersonMS @Eilon