[release/6.0] Dispose CTS in HubConnection streaming #51139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy and
halter73
as code owners
dotnet-issue-labeler
bot
added
the
area-signalr
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
BrennanConroy
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
BrennanConroy
added
Servicing-approved
|
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
|
@BrennanConroy @halter73 I can merge this once it gets code reviewed |
halter73
reviewed
Oct 5, 2023
Co-authored-by: Stephen Halter <halter73@gmail.com>
BrennanConroy
approved these changes
Oct 5, 2023
ghost
added
the
area-infrastructure
rajsite
referenced
this pull request
in ni/nimble
Jan 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [Microsoft.AspNetCore.Components.Web](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `6.0.1` -> `6.0.26` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | nuget | patch | | [Microsoft.AspNetCore.Components.WebAssembly](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `6.0.3` -> `6.0.26` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | nuget | patch | | [Microsoft.AspNetCore.Components.WebAssembly.DevServer](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `6.0.3` -> `6.0.26` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | nuget | patch | | [Microsoft.AspNetCore.Components.WebView.Wpf](https://togithub.com/dotnet/maui) | `6.0.552` -> `6.0.553` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | nuget | patch | | [Microsoft.AspNetCore.Mvc.Testing](https://asp.net/) ([source](https://togithub.com/dotnet/aspnetcore)) | `6.0.1` -> `6.0.26` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | nuget | patch | | [dotnet-sdk](https://togithub.com/dotnet/sdk) | `6.0.202` -> `6.0.418` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dotnet-sdk | patch | --- ### Release Notes <details> <summary>dotnet/aspnetcore (Microsoft.AspNetCore.Components.Web)</summary> ### [`v6.0.26`](https://togithub.com/dotnet/aspnetcore/compare/v6.0.25...v6.0.26) ### [`v6.0.25`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.25): .NET 6.0.25 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.25) #### What's Changed - Fix pRequestInfo INVALID_POINTER_READ caused by GCs (v6 backport) by [@​NGloreous](https://togithub.com/NGloreous) in [https://github.com/dotnet/aspnetcore/pull/50447](https://togithub.com/dotnet/aspnetcore/pull/50447) - \[release/6.0] Update jquery-validation to v1.19.5 by [@​MackinnonBuck](https://togithub.com/MackinnonBuck) in [https://github.com/dotnet/aspnetcore/pull/50484](https://togithub.com/dotnet/aspnetcore/pull/50484) - Merging internal commits for release/6.0 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/50661](https://togithub.com/dotnet/aspnetcore/pull/50661) - Update branding to 6.0.24 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/51115](https://togithub.com/dotnet/aspnetcore/pull/51115) - \[release/6.0] (deps): Bump src/submodules/googletest from `8a6feab` to `e47544a` by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/dotnet/aspnetcore/pull/51049](https://togithub.com/dotnet/aspnetcore/pull/51049) - \[release/6.0] Fix `DragDrop_CanTrigger()` flakiness by [@​MackinnonBuck](https://togithub.com/MackinnonBuck) in [https://github.com/dotnet/aspnetcore/pull/51142](https://togithub.com/dotnet/aspnetcore/pull/51142) - \[release/6.0] Dispose CTS in HubConnection streaming by [@​github-actions](https://togithub.com/github-actions) in [https://github.com/dotnet/aspnetcore/pull/51139](https://togithub.com/dotnet/aspnetcore/pull/51139) - Merging internal commits for release/6.0 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/51265](https://togithub.com/dotnet/aspnetcore/pull/51265) - \[release/6.0] Update dependencies from dotnet/arcade by [@​dotnet-maestro](https://togithub.com/dotnet-maestro) in [https://github.com/dotnet/aspnetcore/pull/51329](https://togithub.com/dotnet/aspnetcore/pull/51329) - Update branding to 6.0.25 by [@​vseanreesermsft](https://togithub.com/vseanreesermsft) in [https://github.com/dotnet/aspnetcore/pull/51478](https://togithub.com/dotnet/aspnetcore/pull/51478) **Full Changelog**: dotnet/aspnetcore@v6.0.24...v6.0.25 ### [`v6.0.24`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.24): .NET 6.0.24 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.24) ### [`v6.0.23`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.23): .NET 6.0.23 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.23) ### [`v6.0.22`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.22): .NET 6.0.22 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.22) ### [`v6.0.21`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.21): .NET 6.0.21 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.21) ### [`v6.0.20`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.20): .NET 6.0.20 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.20) ### [`v6.0.19`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.19): .NET 6.0.19 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.19) ### [`v6.0.18`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.18): .NET 6.0.18 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.18) ### [`v6.0.16`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.16): .NET 6.0.16 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.16) ### [`v6.0.15`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.15): .NET 6.0.15 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.15) ### [`v6.0.14`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.14): .NET 6.0.14 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.14) ### [`v6.0.13`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.13): .NET 6.0.13 [Release](https://togithub.com/dotnet/core/tree/v6.0.13) ### [`v6.0.12`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.12): .NET 6.0.12 [Release](https://togithub.com/dotnet/core/tree/v6.0.12) ### [`v6.0.11`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.11): .NET 6.0.11 [Release](https://togithub.com/dotnet/core/tree/v6.0.11) ### [`v6.0.10`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.10): .NET 6.0.10 [Release](https://togithub.com/dotnet/core/tree/v6.0.10) ### [`v6.0.9`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.9): .NET 6.0.9 [Release](https://togithub.com/dotnet/core/tree/v6.0.9) ### [`v6.0.8`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.8): .NET 6.0.8 [Release](https://togithub.com/dotnet/core/tree/v6.0.8) ### [`v6.0.7`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.7): .NET 6.0.7 [Release](https://togithub.com/dotnet/core/tree/v6.0.7) ### [`v6.0.6`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.6): .NET 6.0.6 [Release](https://togithub.com/dotnet/core/tree/v6.0.6) ### [`v6.0.5`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.5): .NET 6.0.5 [Release](https://togithub.com/dotnet/core/tree/v6.0.5) ### [`v6.0.4`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.4): .NET 6.0.4 [Release](https://togithub.com/dotnet/core/tree/v6.0.4) ### [`v6.0.3`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.3): .NET 6.0.3 [Release](https://togithub.com/dotnet/core/tree/v6.0.3) ### [`v6.0.2`](https://togithub.com/dotnet/aspnetcore/releases/tag/v6.0.2): .NET 6.0.2 [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.2) </details> <details> <summary>dotnet/maui (Microsoft.AspNetCore.Components.WebView.Wpf)</summary> ### [`v6.0.553`](https://togithub.com/dotnet/maui/releases/tag/6.0.553): Service Release 11 [Compare Source](https://togithub.com/dotnet/maui/compare/6.0.552...6.0.553) #### What's Changed - \[net6.0] Updating Microsoft.Windows.SDK.BuildTools to 10.0.22621.756 by [@​MSLukeWest](https://togithub.com/MSLukeWest) in [https://github.com/dotnet/maui/pull/14106](https://togithub.com/dotnet/maui/pull/14106) - \[net6.0] Microsoft.Windows.SDK.BuildTools can be transitive by [@​mattleibow](https://togithub.com/mattleibow) in [https://github.com/dotnet/maui/pull/14435](https://togithub.com/dotnet/maui/pull/14435) - \[net6.0] Update dependencies from xamarin/xamarin-macios to support Xcode 14.3 by [@​dalexsoto](https://togithub.com/dalexsoto) in [https://github.com/dotnet/maui/pull/14675](https://togithub.com/dotnet/maui/pull/14675) - \[release/6.0.5xx-sr11] Update version branding by [@​Redth](https://togithub.com/Redth) in [https://github.com/dotnet/maui/pull/14747](https://togithub.com/dotnet/maui/pull/14747) **Full Changelog**: dotnet/maui@6.0.552...6.0.553 </details> <details> <summary>dotnet/sdk (dotnet-sdk)</summary> ### [`v6.0.418`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.418): .NET 6.0.26 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.417...v6.0.418) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.26) ### [`v6.0.417`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.417): .NET 6.0.25 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.416...v6.0.417) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.25) ### [`v6.0.416`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.416): .NET 6.0.24 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.415...v6.0.416) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.24) ### [`v6.0.415`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.415): .NET 6.0.23 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.414...v6.0.415) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.23) ### [`v6.0.414`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.414): .NET 6.0.22 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.413...v6.0.414) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.22) ### [`v6.0.413`](https://togithub.com/dotnet/sdk/compare/v6.0.412...v6.0.413) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.412...v6.0.413) ### [`v6.0.412`](https://togithub.com/dotnet/sdk/compare/v6.0.411...v6.0.412) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.411...v6.0.412) ### [`v6.0.411`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.411): .NET 6.0.19 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.410...v6.0.411) https://github.com/dotnet/core/releases/tag/v6.0.19 ### [`v6.0.410`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.410): .NET 6.0.18 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.408...v6.0.410) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.18) ### [`v6.0.408`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.408): .NET 6.0.16 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.407...v6.0.408) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.16) ### [`v6.0.407`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.407): .NET 6.0.15 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.406...v6.0.407) [Release](https://togithub.com/dotnet/core/releases/tag/v6.0.15) ### [`v6.0.406`](https://togithub.com/dotnet/sdk/compare/v6.0.405...v6.0.406) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.405...v6.0.406) ### [`v6.0.405`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.405): .NET SDK 6.0.405 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.404...v6.0.405) [Release](https://togithub.com/dotnet/core/tree/v6.0.13) ### [`v6.0.404`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.404): .NET SDK 6.0.404 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.403...v6.0.404) [Release](https://togithub.com/dotnet/core/tree/v6.0.12) ### [`v6.0.403`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.403): .NET SDK 6.0.403 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.402...v6.0.403) [Release](https://togithub.com/dotnet/core/tree/v6.0.11) ### [`v6.0.402`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.402): .NET SDK 6.0.402 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.401...v6.0.402) [Release](https://togithub.com/dotnet/core/tree/v6.0.10) ### [`v6.0.401`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.401): .NET SDK 6.0.401 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.400...v6.0.401) [Release](https://togithub.com/dotnet/core/tree/v6.0.9) ### [`v6.0.400`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.400): .NET SDK 6.0.400 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.321...v6.0.400) [Release](https://togithub.com/dotnet/core/tree/v6.0.8) ### [`v6.0.321`](https://togithub.com/dotnet/sdk/compare/v6.0.320...v6.0.321) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.320...v6.0.321) ### [`v6.0.320`](https://togithub.com/dotnet/sdk/compare/v6.0.319...v6.0.320) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.319...v6.0.320) ### [`v6.0.319`](https://togithub.com/dotnet/sdk/compare/v6.0.318...v6.0.319) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.318...v6.0.319) ### [`v6.0.318`](https://togithub.com/dotnet/sdk/compare/v6.0.317...v6.0.318) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.317...v6.0.318) ### [`v6.0.317`](https://togithub.com/dotnet/sdk/compare/v6.0.316...v6.0.317) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.316...v6.0.317) ### [`v6.0.316`](https://togithub.com/dotnet/sdk/compare/v6.0.315...v6.0.316) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.315...v6.0.316) ### [`v6.0.315`](https://togithub.com/dotnet/sdk/compare/v6.0.314...v6.0.315) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.314...v6.0.315) ### [`v6.0.314`](https://togithub.com/dotnet/sdk/compare/v6.0.313...v6.0.314) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.313...v6.0.314) ### [`v6.0.313`](https://togithub.com/dotnet/sdk/compare/v6.0.311...v6.0.313) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.311...v6.0.313) ### [`v6.0.311`](https://togithub.com/dotnet/sdk/compare/v6.0.310...v6.0.311) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.310...v6.0.311) ### [`v6.0.310`](https://togithub.com/dotnet/sdk/compare/v6.0.309...v6.0.310) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.309...v6.0.310) ### [`v6.0.309`](https://togithub.com/dotnet/sdk/compare/v6.0.308...v6.0.309) [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.308...v6.0.309) ### [`v6.0.308`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.308): .NET SDK 6.0.308 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.307...v6.0.308) [Release](https://togithub.com/dotnet/core/tree/v6.0.13) ### [`v6.0.307`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.307): .NET SDK 6.0.307 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.306...v6.0.307) [Release](https://togithub.com/dotnet/core/tree/v6.0.12) ### [`v6.0.306`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.306): .NET SDK 6.0.306 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.305...v6.0.306) [Release](https://togithub.com/dotnet/core/tree/v6.0.11) ### [`v6.0.305`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.305): .NET SDK 6.0.305 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.304...v6.0.305) [Release](https://togithub.com/dotnet/core/tree/v6.0.10) ### [`v6.0.304`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.304): .NET SDK 6.0.304 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.303...v6.0.304) [Release](https://togithub.com/dotnet/core/tree/v6.0.9) ### [`v6.0.303`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.303): .NET SDK 6.0.303 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.302...v6.0.303) [Release](https://togithub.com/dotnet/core/tree/v6.0.8) ### [`v6.0.302`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.302): .NET SDK 6.0.302 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.301...v6.0.302) [Release](https://togithub.com/dotnet/core/tree/v6.0.7) ### [`v6.0.301`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.301): .NET SDK 6.0.301 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.300...v6.0.301) [Release](https://togithub.com/dotnet/core/tree/v6.0.6) ### [`v6.0.300`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.300): .NET SDK 6.0.300 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.203...v6.0.300) [Release](https://togithub.com/dotnet/core/tree/v6.0.5) ### [`v6.0.203`](https://togithub.com/dotnet/sdk/releases/tag/v6.0.203): .NET SDK 6.0.203 [Compare Source](https://togithub.com/dotnet/sdk/compare/v6.0.202...v6.0.203) [Release](https://togithub.com/dotnet/core/tree/v6.0.5) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "monthly" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ni/nimble). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuMTI3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Meyer <26874831+atmgrifter00@users.noreply.github.com> Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
This was referenced Jul 3, 2024
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #51117 to release/6.0
/cc @BrennanConroy
Dispose CTS in HubConnection streaming
Description
Fixes a memory leak in the SignalR client when using streaming.
Customer Impact
Noticed by customer when running a service with a client for multiple weeks and seeing large memory usage. Could also be seen by a more active client that makes a lot of streaming calls.
Regression?
Looks like it's been there since 3.X
Risk
Simple disposal of an object once it's done being used.
Verification
Packaging changes reviewed?