Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTTPS URLs for json.schemastore.org #52203

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Use HTTPS URLs for json.schemastore.org #52203

merged 1 commit into from
Nov 21, 2023

Conversation

glen-84
Copy link
Contributor

@glen-84 glen-84 commented Nov 20, 2023 •
edited
Loading

Use HTTPS URLs for json.schemastore.org

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Use HTTPS URLs for json.schemastore.org.

Description

Updated all HTTP URLs for json.schemastore.org to use HTTPS.

Fixes #51168

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 20, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Nov 20, 2023
@ghost
Copy link

ghost commented Nov 20, 2023

Thanks for your PR, @glen-84. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@glen-84
Copy link
Contributor Author

glen-84 commented Nov 20, 2023

@dotnet-policy-service agree

@captainsafia
Copy link
Member

This seems fine to merge to .NET 9. If it's problematic with VS or another target, we can always revert but I don't foresee that being the case.

@captainsafia captainsafia merged commit 7de6235 into dotnet:main Nov 21, 2023
26 checks passed
@ghost ghost added this to the 9.0-preview1 milestone Nov 21, 2023
@glen-84 glen-84 deleted the schemastore-https branch November 21, 2023 18:29
@eerhardt eerhardt mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

@mgravell mgravell Awaiting requested review from mgravell mgravell is a code owner

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
9.0-preview1
Development

Successfully merging this pull request may close these issues.

Schema URL in templated launchSettings.json should use HTTPS
2 participants
@glen-84 @captainsafia