Delete Stale Chunks #52272
Merged
Delete Stale Chunks #52272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
added
area-auth
amcasey
reviewed
Nov 22, 2023
|
Test failures. You want us to finish this up or you still available to push it through? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4639 for my younger mistakes.
Browsers have limits on how large cookies can be, so we chunk auth cookies by default. If that cookie suddenly shrinks then we don't clean up old chunks. Normally we'd just let the old chunks expire but they can cause issues in some cases where the new cookie plus the old chunk is greater than the servers header size limit.
This fix tries to only delete chunks that won't be overwritten by new ones.