[Blazor] Avoid fetching new page content when only the hash changes #53341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Jan 16, 2024
...tassets/Components.TestServer/RazorComponents/Pages/EnhancedNav/PageForScrollingToHash.razor
Show resolved
Hide resolved
javiercn
reviewed
Jan 18, 2024
javiercn
approved these changes
Jan 18, 2024
MackinnonBuck
added a commit
that referenced
this pull request
Jan 22, 2024
10 tasks
wtgodbe
pushed a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid fetching new page content when only the hash changes
Fixes an issue where a page request is made after clicking a link that only updates the hash part of the URL.
The PR fixes the bug by updating the behavior to match what browsers do by default - if the hash is the only part of the URL that changes, scroll to the element with the ID of the new hash.
This was already implemented correctly for interactive routing, so this PR updates enhanced navigation to share the same logic.
Fixes #52583