[Blazor] Enable regex constraint on the Blazor router #53533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-blazor
javiercn
commented
Jan 22, 2024
javiercn
force-pushed
the
javiercn/enable-regex-constraint
branch
2 times, most recently
from
fb37227 to
d3b20c9
Compare
This was discovered when working on the issue for #53138. The regex constraint is not enabled by default on the blazor router. As a result if a route uses a regex constraint, it will work on SSR but will fail the moment the Blazor router tries to construct the route. The fix enables the regex constraint on the blazor router, unconditionally for server, and behind a feature flag for webassembly. This is because enabling the regex constraint adds +80kb to the payload due to the inclusion of the System.Text.RegularExpressions assembly.
javiercn
force-pushed
the
javiercn/enable-regex-constraint
branch
from
d3b20c9 to
788a28c
Compare
|
This should now be ok for review |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Blazor] Enable regex constraint in Blazor routing
This was discovered when working on the issue for #53138. The regex
constraint is not enabled by default on the blazor router.
As a result if a route uses a regex constraint, it will work on SSR but
will fail the moment the Blazor router tries to construct the route.
The fix enables the regex constraint on the blazor router,
unconditionally for server, and behind a feature flag for webassembly.
This is because enabling the regex constraint adds +80kb to the payload
due to the inclusion of the
System.Text.RegularExpressionsassembly.