[Blazor] Fixes encoded / on Blazor Router
#53538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the routing unification process we switched the way we were decoding the URL prior to feeding it to routing and that introduced a small regression in interactive routing compared to .NET 7.0. This commit fixes that regression by using the same logic for decoding the URL in the client that is used on the server. In addition to that, the Blazor router now post processes the URL to replace instances of `%2F` with `/` when providing values to maintain the behavior in 7.0 where it used UnescapeDataString. This also makes the routing on the server and on the client consistent in their handling of encoded `/` characters.
dotnet-issue-labeler
bot
added
the
area-blazor
javiercn
added
the
Servicing-consider
|
Hi @javiercn. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
MackinnonBuck
approved these changes
Feb 1, 2024
mkArtakMSFT
added
Servicing-approved
|
Hi @javiercn. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
dotnet-policy-service
bot
added
the
area-infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of encoded values within Blazor Routing
As part of .NET 8.0 we replaced the Blazor Router implementation with an equivalent implementation provided by ASP.NET to bring the Blazor implementation to out of the box feature parity with the ASP.NET implementation.
As part of that, we changed the way encoded are processed before we handle them to the Blazor router, which resulted in a regression as we were eagerly decoding
%2F(/) values. In addition to that, we also determined that the values were not being decoded (a custom step that Blazor does)Description
%2Fcharacters in the path before running routing.Fixes #52808, #53138, #53262 #53668
Customer Impact
/in their application paths (for example, route parameters that take in a URL) won't be able to do so.Regression?
7.0, the values were presented unencoded to the user and
%2Fwas handled correctly and route values were decoded before being passed as parameters.Risk
We've added automated tests to validate that the scenario behaves correctly and tests that verify that the implementation on the server and the client behaves consistently and accordingly to previous Blazor versions.
We've replaced the implementation that was handling the decoding in the Blazor Router (which was the source of the problem) with the implementation used by ASP.NET Core.
Verification
Packaging changes reviewed?
When servicing release/2.1