Skip to content

[release/8.0] Fix navigation for anchor inside <svg> element #53541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Jan 22, 2024

[release/8.0] Fix navigation for anchor inside <svg> element

Backport of #51706

Fixes multiple issues involving navigations initiated by clicks on <a> elements used in conjunction with <svg> elements.

Description

Makes the following improvements to how navigation interacts with <svg> elements:

Fixes #51705
Fixes #51440
Fixes #52205

Customer Impact

Variations of this issue have been reported by several customers. Two of the abovementioned issues were reported before 8.0 GA, but this fix didn't make the GA cutoff. Since GA, a third variation of this issue has been reported, and it has received a couple upvotes by the community. There's no known workaround for these issues.

Regression?

  • Yes
  • No

This behavior has existed since the introduction of enhanced navigation (.NET 8).

Risk

  • High
  • Medium
  • Low

The change is straightforward and pertains to a well-tested area of the framework.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

* fix enhanced nav for svg element

* small fix

* simplify findClosestAnchorAncestorLegacy

* added test for svg element inside anchor

* removed _blazorDisableComposedPath  logic and findClosestAnchorAncestorLegacy function

* added test for anchor inside svg element dor client-side navigation

* added SVGAElement to findAnchorTarget and
@MackinnonBuck MackinnonBuck added Servicing-consider Shiproom approval is required for the issue area-blazor Includes: Blazor, Razor Components labels Jan 22, 2024
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner January 22, 2024 23:30
@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 23, 2024
@ghost
Copy link

ghost commented Jan 31, 2024

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 31, 2024
@wtgodbe wtgodbe merged commit 32ba87f into release/8.0 Feb 6, 2024
@wtgodbe wtgodbe deleted the mbuck/backport-51706 branch February 6, 2024 22:29
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.3 milestone Feb 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants